present tense - "She has" vs. "she had" been trying to give up smoking for years

Both are fine, but they have slightly different meanings.

The first sounds like Cindy kept trying to give up until she succeeded (as it were :) ).

The second sounds like Cindy tried to give up, stopped trying to give up, then made another (finally successful) attempt.